Feat: instrument aiohttp with trace_configs argument #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/aiohttp-trace-configs
|
Please do resolve build errors |
|
still 9 checks are failing. @nemoshlag : Can you please look into that |
srikanthccv
reviewed
May 10, 2022
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Outdated
Show resolved
Hide resolved
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
May 18, 2022
| @@ -262,6 +262,7 @@ def _instrument( | |||
| url_filter: _UrlFilterT = None, | |||
| request_hook: _RequestHookT = None, | |||
| response_hook: _ResponseHookT = None, | |||
| trace_configs: list = (), | |||
There was a problem hiding this comment.
Default value here is tuple, not list
srikanthccv
reviewed
Jun 5, 2022
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Outdated
Show resolved
Hide resolved
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Outdated
Show resolved
Hide resolved
…b into feat/aiohttp-trace-configs
|
@nemoshlag This is easy fix. Please address the comments and it should be ready to merge. |
srikanthccv
reviewed
Jun 25, 2022
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Outdated
Show resolved
Hide resolved
… feat/aiohttp-trace-configs
srikanthccv
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding trace_configs argument to aiohttp client wrapper enables additional customization. For instance, on_request_chunk_sent event is called after span was created and before request was ended - making it impossible to capture data chunks when using request or response hooks.
Fixes #1073 (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The trace_configs feature is already integrated and tested with aiohttp wrapper library (https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py).
An additional test was added to verify new functionality - creating 2 spans with passing trace_configs as an argument to instrument func.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.